Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant adodbapi warning #19557

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 6, 2022

SUMMARY

The adodbapi dialect appears to be the only dialect included in SQLAlchemy 1.3 that doesn't implement the dbapi() method, and is fully removed in 1.4. To avoid logging a confusing warning, we should avoid trying to use the driver until we bump to 1.4.

BEFORE

Previous to this check, the following would regularly pop up on logs:

2022-04-06 13:31:24,380:WARNING:superset.db_engine_specs:Unable to load dialect <class 'sqlalchemy.dialects.mssql.adodbapi.MSDialect_adodbapi'>: type object 'MSDialect_adodbapi' has no attribute 'dbapi'

TESTING INSTRUCTIONS

Call http://host/api/v1/database/available/ and make sure the you get the same available drivers as before, but no warning on the logs.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #19557 (5d34f96) into master (e1ef2ba) will decrease coverage by 12.65%.
The diff coverage is 0.00%.

❗ Current head 5d34f96 differs from pull request most recent head 3454ec6. Consider uploading reports for the commit 3454ec6 to get more accurate results

@@             Coverage Diff             @@
##           master   #19557       +/-   ##
===========================================
- Coverage   66.59%   53.93%   -12.66%     
===========================================
  Files        1682     1678        -4     
  Lines       64321    64261       -60     
  Branches     6561     6561               
===========================================
- Hits        42837    34662     -8175     
- Misses      19783    27898     +8115     
  Partials     1701     1701               
Flag Coverage Δ
hive 52.70% <ø> (-0.01%) ⬇️
mysql ?
postgres ?
presto 52.55% <ø> (-0.01%) ⬇️
python 56.50% <ø> (-25.89%) ⬇️
sqlite ?
unit 47.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.73% <0.00%> (ø)
superset/db_engine_specs/__init__.py 84.61% <ø> (-3.85%) ⬇️
superset/models/sql_lab.py 84.41% <ø> (-7.15%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 14.79% <0.00%> (-75.15%) ⬇️
superset/datasets/commands/importers/v0.py 24.82% <0.00%> (-68.80%) ⬇️
... and 267 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ef2ba...3454ec6. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 0d331f5 into apache:master Apr 7, 2022
@villebro villebro deleted the villebro/adodbapi-red-herring branch April 7, 2022 11:30
villebro added a commit that referenced this pull request Apr 8, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants