Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz-gallery): add search weight for viz-name #19581

Merged
merged 1 commit into from
May 13, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Apr 7, 2022

SUMMARY

The current search weight is name(1) = tags(1) = description(1), sometimes search results don't match expectations. Here we set the search weight for name(4) > tags(2) > description(1).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ requested review from suddjian and rusackas May 9, 2022 14:41
@zhaoyongjie zhaoyongjie self-requested a review May 13, 2022 13:43
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM.
@kasiazjc a little question for this. Do we need to search description on this? for example, When I searched bar in the search bar then the viz description with bar can be searched, sometimes this results confused me.

@stephenLYZ stephenLYZ merged commit e625c03 into apache:master May 13, 2022
@kasiazjc
Copy link
Contributor

code LGTM. @kasiazjc a little question for this. Do we need to search description on this? for example, When I searched bar in the search bar then the viz description with bar can be searched, sometimes this results confused me.

I think you are actually right - the description should not be included in the search as it is super confusing. Name and tags should be enough.

@lauderbaugh any thoughts?

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants