Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navbar styles and Welcome page text #19586

Merged
merged 3 commits into from
Apr 12, 2022
Merged

fix: Navbar styles and Welcome page text #19586

merged 3 commits into from
Apr 12, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 7, 2022

SUMMARY

It fixes an issue with the text in the Welcome page not appearing as reported here #19579. It also enhances the styles to follow our guidelines.

BEFORE

image

AFTER

DEV.Superset.mp4

TESTING INSTRUCTIONS

  1. Go to the login page and make sure the logo appears in the right size immediately
  2. Go to the Welcome page and make sure the text "Home" at the top is displaying correctly.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from etr2460 April 7, 2022 12:04
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

superset-frontend/src/views/CRUD/welcome/Welcome.tsx Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/welcome/Welcome.tsx Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/welcome/Welcome.tsx Outdated Show resolved Hide resolved
superset-frontend/src/views/CRUD/welcome/Welcome.tsx Outdated Show resolved Hide resolved
@geido geido requested a review from etr2460 April 8, 2022 15:37
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the css improvements, lgtm!

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #19586 (8ee288c) into master (7b0b029) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8ee288c differs from pull request most recent head 392a9bb. Consider uploading reports for the commit 392a9bb to get more accurate results

@@            Coverage Diff             @@
##           master   #19586      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.01%     
==========================================
  Files        1681     1681              
  Lines       64467    64448      -19     
  Branches     6607     6607              
==========================================
- Hits        42856    42837      -19     
  Misses      19917    19917              
  Partials     1694     1694              
Flag Coverage Δ
javascript 51.12% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 74.22% <100.00%> (-0.78%) ⬇️
superset-frontend/src/views/components/Menu.tsx 50.00% <100.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0b029...392a9bb. Read the comment docs.

@geido geido merged commit 59dda1f into apache:master Apr 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Enhance navbar styles

* Clean up style
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants