-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Navbar styles and Welcome page text #19586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the css improvements, lgtm!
Codecov Report
@@ Coverage Diff @@
## master #19586 +/- ##
==========================================
- Coverage 66.47% 66.46% -0.01%
==========================================
Files 1681 1681
Lines 64467 64448 -19
Branches 6607 6607
==========================================
- Hits 42856 42837 -19
Misses 19917 19917
Partials 1694 1694
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Enhance navbar styles * Clean up style
SUMMARY
It fixes an issue with the text in the Welcome page not appearing as reported here #19579. It also enhances the styles to follow our guidelines.
BEFORE
AFTER
DEV.Superset.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION