Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): More explicit labels of adhoc filter operators #19691

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

  1. Change order of operators
  2. Replace all caps with sentence case
  3. Change labels to be more explicit (for example replace < with Less than (<)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

Verify that the adhoc filter operators work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #19691 (9c79fcd) into master (ee85466) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19691      +/-   ##
==========================================
- Coverage   66.50%   66.50%   -0.01%     
==========================================
  Files        1683     1684       +1     
  Lines       64529    64536       +7     
  Branches     6610     6616       +6     
==========================================
+ Hits        42917    42921       +4     
  Misses      19917    19917              
- Partials     1695     1698       +3     
Flag Coverage Δ
javascript 51.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/explore/constants.ts 100.00% <ø> (ø)
...rset-frontend/src/dashboard/util/findPermission.ts 92.30% <0.00%> (-7.70%) ⬇️
...perset-frontend/src/views/components/MenuRight.tsx 66.66% <0.00%> (-1.15%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.89% <0.00%> (-0.17%) ⬇️
superset-frontend/src/types/bootstrapTypes.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee85466...9c79fcd. Read the comment docs.

@kgabryje kgabryje merged commit b81982d into apache:master Apr 13, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants