chore(build): upgrade less-loader

[ktmud]

SUMMARY

npm install starts to complain about incompatible peerDependencies:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: less-loader@5.0.0
npm ERR! Found: webpack@5.52.1
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^5.52.1" from the root project
npm ERR!   peerOptional webpack@">=4" from @cypress/react@5.10.1
npm ERR!   node_modules/@cypress/react
npm ERR!     dev @cypress/react@"^5.10.0" from the root project
npm ERR!   33 more (@storybook/addon-essentials, @storybook/addon-docs, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from less-loader@5.0.0
npm ERR! node_modules/less-loader
npm ERR!   dev less-loader@"^5.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: webpack@4.46.0
npm ERR! node_modules/webpack
npm ERR!   peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from less-loader@5.0.0
npm ERR!   node_modules/less-loader
npm ERR!     dev less-loader@"^5.0.0" from the root project
npm ERR! 

Let's upgrade less-loader to fix it.

Also removing engine requirement in the eslint-plugin-theme-colors plugin as it's throwing unnecessary warnings.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Tested locally and all CSS seems still work

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19703 (95de193) into master (34008f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19703   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1686     1686           
  Lines       64589    64589           
  Branches     6635     6635           
=======================================
  Hits        42959    42959           
  Misses      19931    19931           
  Partials     1699     1699           

Flag	Coverage Δ
javascript	51.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34008f7...95de193. Read the comment docs.

[ktmud]

/testenv up

[github-actions]

@ktmud Ephemeral environment spinning up at http://35.89.103.133:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

Thanks for this!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[codemaster08240328]

@ktmud , after this update, I removed all my node modules, installed it again.
Then when I try to run frontend using npm run dev-server it throws an error:

ERROR in ./src/assets/stylesheets/antd/index.less (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[5].use[1]!./node_modules/less-loader/dist/cjs.js??ruleSet[1].rules[5].use[2]!./src/assets/stylesheets/antd/index.less)
Module build failed (from ./node_modules/less-loader/dist/cjs.js):


// @import './variable.less';
@import './@{root-entry-name}.less';
      ^
Variable @root-entry-name is undefined
      Error in /Volumes/Work/assignment/preset/superset/superset-frontend/node_modules/antd/lib/style/themes/index.less (line 7, column 8)

Can you please check it?

[ktmud]

@codemaster08240328 did you modify ./src/assets/stylesheets/antd/index.less locally by any chance? I don't think the variable root-entry-name is in current Superset codebase.