-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-dev-server): parse env args #19744
fix(webpack-dev-server): parse env args #19744
Conversation
+1, the patch work well on my local dev environment, thanks @jdbranham |
that solved connection problem, thx! |
Sorry this never got a review somehow. Adding a few folks to review/test this. I'm also closing/reopening to kick-start CI, and see if we can get this thing across the finish line. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19744 +/- ##
==========================================
+ Coverage 66.51% 68.43% +1.92%
==========================================
Files 1687 1840 +153
Lines 64623 70219 +5596
Branches 6646 8275 +1629
==========================================
+ Hits 42983 48054 +5071
- Misses 19940 20114 +174
- Partials 1700 2051 +351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
The
--superset
arg is rejected by webpack because it's not well known.This PR updates the documentation and changes the flag to use the
--env
arg as a way to override the backend superset environment when running thewebpack-dev-server
.TESTING INSTRUCTIONS
From the
superset-frontend
directory, run the command to use a remote superset backend.ADDITIONAL INFORMATION