Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-dev-server): parse env args #19744

Conversation

jdbranham
Copy link
Contributor

SUMMARY

The --superset arg is rejected by webpack because it's not well known.

This PR updates the documentation and changes the flag to use the --env arg as a way to override the backend superset environment when running the webpack-dev-server.

TESTING INSTRUCTIONS

From the superset-frontend directory, run the command to use a remote superset backend.

npm run dev-server -- --env=--superset=https://my-superset-backend

ADDITIONAL INFORMATION

  • Has associated issue: Fixes webpack-cli throws 'Unknown option' error when using --superset arg #19743
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@vivostar
Copy link

vivostar commented Jul 6, 2022

+1, the patch work well on my local dev environment, thanks @jdbranham

@TacoBel42
Copy link

that solved connection problem, thx!

@rusackas
Copy link
Member

rusackas commented Feb 6, 2024

Sorry this never got a review somehow. Adding a few folks to review/test this. I'm also closing/reopening to kick-start CI, and see if we can get this thing across the finish line.

@rusackas rusackas closed this Feb 6, 2024
@rusackas rusackas reopened this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae70212) 66.51% compared to head (2c4396c) 68.43%.
Report is 3191 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19744      +/-   ##
==========================================
+ Coverage   66.51%   68.43%   +1.92%     
==========================================
  Files        1687     1840     +153     
  Lines       64623    70219    +5596     
  Branches     6646     8275    +1629     
==========================================
+ Hits        42983    48054    +5071     
- Misses      19940    20114     +174     
- Partials     1700     2051     +351     
Flag Coverage Δ
javascript 56.91% <ø> (+5.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e986a17 into apache:master Feb 7, 2024
34 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-cli throws 'Unknown option' error when using --superset arg
5 participants