fix(permalink): remove memoize on get salt func

[villebro]

SUMMARY

Currently the util function that fetches the permalink salt is memoized. This can cause trouble if the workers need to reference different metastores. While removal of the memoized decorator will have a performance impact, it should be negligible, as it's very light weight and occurs fairly infrequently. I will look into a better solution for avoiding refetching the salt on each permalink action.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Decoding a permalink with a salt different to that with which it was encrypted results in the following error:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[zhaoyongjie]

LGTM

[codecov]

Codecov Report

Merging #19749 (1016dc4) into master (57157c8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19749      +/-   ##
==========================================
- Coverage   66.51%   66.51%   -0.01%     
==========================================
  Files        1687     1687              
  Lines       64620    64618       -2     
  Branches     6646     6646              
==========================================
- Hits        42980    42978       -2     
  Misses      19940    19940              
  Partials     1700     1700              

Flag	Coverage Δ
hive	52.69% <ø> (-0.01%)	⬇️
mysql	81.95% <ø> (-0.01%)	⬇️
postgres	82.00% <ø> (-0.01%)	⬇️
presto	52.54% <ø> (-0.01%)	⬇️
python	82.42% <ø> (-0.01%)	⬇️
sqlite	81.76% <ø> (-0.01%)	⬇️
unit	47.75% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/key_value/shared_entries.py	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57157c8...1016dc4. Read the comment docs.

[sadpandajoe]

🏷️ preset:2022.15