fix(world-map): remove categorical color control #19781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR reverts the changes in #19038 that affected world maps. #19038 added a control
CATEGORICAL COLOR SCHEME
to world maps which could override the linear color scheme if specified. This inadvertently broke all linear coloring for our world map charts because it was not possible to specify a null categorical color scheme.Rather than fix the behavior of the categorical color scheme, I thought a better fix might be to just remove the categorical color scheme feature from world maps. World maps require the
METRIC FOR COLOR
control, so I'm not sure it makes sense to support a categorical color scheme.TESTING INSTRUCTIONS
Make world map chart with linear color scheme, confirm colors applied as expected
ADDITIONAL INFORMATION
@stephenLYZ @zhaoyongjie