Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump postgres from 10 to 14 #19790

Merged
merged 8 commits into from
Apr 21, 2022
Merged

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 20, 2022

SUMMARY

Postgres 11.0 change log: https://www.postgresql.org/docs/release/11.0/
Postgres 12.0 change log: https://www.postgresql.org/docs/release/12.0/
Postgres 13.0 change log: https://www.postgresql.org/docs/release/12.0/
Postgres 14.0 change log: https://www.postgresql.org/docs/release/14.0/

Also updates helm postgres bitnami chart to 11.1.22, that sets postgres to 14.2:
https://github.com/bitnami/charts/blob/master/bitnami/postgresql/values.yaml#L90

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

Two more things I think we should do:

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #19790 (5a9b017) into master (22a92ed) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 5a9b017 differs from pull request most recent head c65caa5. Consider uploading reports for the commit c65caa5 to get more accurate results

@@            Coverage Diff             @@
##           master   #19790      +/-   ##
==========================================
+ Coverage   66.40%   66.54%   +0.13%     
==========================================
  Files        1690     1692       +2     
  Lines       64732    64775      +43     
  Branches     6656     6661       +5     
==========================================
+ Hits        42987    43103     +116     
+ Misses      20046    19972      -74     
- Partials     1699     1700       +1     
Flag Coverage Δ
hive 52.85% <ø> (?)
javascript 51.24% <ø> (+0.03%) ⬆️
mysql 81.90% <ø> (+0.01%) ⬆️
postgres 81.95% <ø> (+0.01%) ⬆️
presto 52.70% <ø> (-0.02%) ⬇️
python 82.37% <ø> (+0.23%) ⬆️
sqlite 81.71% <ø> (+0.01%) ⬆️
unit 47.93% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/Collapse/index.tsx 90.00% <0.00%> (-10.00%) ⬇️
superset/constants.py 100.00% <0.00%> (ø)
superset/dashboards/api.py 92.73% <0.00%> (ø)
superset/utils/pandas_postprocessing/flatten.py 100.00% <0.00%> (ø)
superset/utils/pandas_postprocessing/__init__.py 100.00% <0.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <0.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <0.00%> (ø)
...rc/explore/components/controls/CheckboxControl.jsx 100.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a92ed...c65caa5. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 20, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few non-blocking comments. And big thanks for adding the detailed docs - this piece of documentation has been sorely needed for a long time!

@@ -69,6 +69,32 @@ you can add the endpoints to `WTF_CSRF_EXEMPT_LIST`:
WTF_CSRF_EXEMPT_LIST = [‘’]
```

### Using a production metadata database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've started to prefer the term "metastore", as "metadata database" is a bit of a tongue twister. But we can do a full update of that in a follow-up PR.

docs/docs/installation/configuring-superset.mdx Outdated Show resolved Hide resolved
docs/docs/installation/configuring-superset.mdx Outdated Show resolved Hide resolved
dpgaspar and others added 4 commits April 21, 2022 08:50
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@dpgaspar dpgaspar merged commit 3db4a1c into apache:master Apr 21, 2022
@dpgaspar dpgaspar deleted the chore/bump-pg branch April 21, 2022 09:16
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* chore: bump postgres from 10 to 14

* update helm chart

* adding docs

* fix docs

* Update docs/docs/installation/configuring-superset.mdx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update docs/docs/installation/configuring-superset.mdx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve docs

* improve docs

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* chore: bump postgres from 10 to 14

* update helm chart

* adding docs

* fix docs

* Update docs/docs/installation/configuring-superset.mdx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update docs/docs/installation/configuring-superset.mdx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve docs

* improve docs

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants