docs: Detail front-end development instructions #19870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EBoisseauSierra
changed the title
Automatically done using the Markdown-All-In-One extension for VSCode: https://open-vsx.org/extension/yzhang/markdown-all-in-one Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
Based on the silly error that led to [this discussion](https://apache-superset.slack.com/archives/C014LS99C1K/p1650969237848999), we clarify that when modifying the front-end locally, one should access the Webpack dev servers, rather than Flask directly, to see the latest changes take effect. Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
EBoisseauSierra
force-pushed
the
docs_for_dummies
branch
from
a3320f9 to
014a55a
Compare
EBoisseauSierra
changed the title
rusackas
reviewed
Apr 27, 2022
CONTRIBUTING.md
Outdated
| Concretely, it means that you will want to: | ||
|
|
||
| 1. [run Superset locally](#flask-server) using Flask, on port `8088`, | ||
| 2. in parallel, run the Webpack dev server locally on port `9000`, |
There was a problem hiding this comment.
Not sure if this is a good place to mention that you can run npm run dev or (what most people do) npm run dev-server for hot reloading
There was a problem hiding this comment.
Thanks! Would that make things clearer?
Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
EBoisseauSierra
force-pushed
the
docs_for_dummies
branch
from
ed265f3 to
94aab8f
Compare
rusackas
approved these changes
May 11, 2022
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
* chore: Beautify CONTRIBUTING Automatically done using the Markdown-All-In-One extension for VSCode: https://open-vsx.org/extension/yzhang/markdown-all-in-one Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io> * docs: Detail front-end development instructions Based on the silly error that led to [this discussion](https://apache-superset.slack.com/archives/C014LS99C1K/p1650969237848999), we clarify that when modifying the front-end locally, one should access the Webpack dev servers, rather than Flask directly, to see the latest changes take effect. Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io> * docs: Underline typical workflow Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* chore: Beautify CONTRIBUTING Automatically done using the Markdown-All-In-One extension for VSCode: https://open-vsx.org/extension/yzhang/markdown-all-in-one Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io> * docs: Detail front-end development instructions Based on the silly error that led to [this discussion](https://apache-superset.slack.com/archives/C014LS99C1K/p1650969237848999), we clarify that when modifying the front-end locally, one should access the Webpack dev servers, rather than Flask directly, to see the latest changes take effect. Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io> * docs: Underline typical workflow Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Based on the silly error that led to this
discussion,
we clarify that when modifying the front-end locally, one should access
the Webpack dev servers, rather than Flask directly, to see the latest
changes take effect.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
TESTING INSTRUCTIONS
n/a
ADDITIONAL INFORMATION