fix(chart & alert): make to show metrics properly #19939
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19939 +/- ##
==========================================
- Coverage 66.53% 66.52% -0.01%
==========================================
Files 1714 1714
Lines 65044 65063 +19
Branches 6723 6721 -2
==========================================
+ Hits 43278 43286 +8
- Misses 20055 20069 +14
+ Partials 1711 1708 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://54.201.182.210:8080. Credentials are |
|
@prosdev0107 I see metrics twice in the control panel now: |
|
I don't think this is the right way to fix this issue. You'd probably want to update the "Chart changes" renderer instead of the customized metrics controls. |
| @@ -263,6 +263,7 @@ const config: ControlPanelConfig = { | |||
| }, | |||
| ], | |||
| ['adhoc_filters'], | |||
| ['metrics'], | |||
There was a problem hiding this comment.
check instead what is the other metrics panel doing, it must be transforming the props or something
| if (typeof value === 'boolean') { | ||
| return value ? 'true' : 'false'; | ||
| } | ||
| if (value.constructor === Array) { | ||
| return value.length ? value.join(', ') : '[]'; | ||
| const formattedValue = value.map(v => (v.label ? v.label : v)); |
There was a problem hiding this comment.
This could potentially be called for other control types aside from metrics.
Why did you move it from above? Was the code not entering? We're essentially switching from Array.isArray to value.constructor, which should have similar effect.
If that's the only reason, we could replace Array.isArray with value.constructor in the other block you removed, but keeping it locked to the metrics control.
There was a problem hiding this comment.
@diegomedina248
It does make sense. Resolved.
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://52.11.190.164:8080. Credentials are |
|
a quick test on the ephemeral was looking good to me |
|
Ephemeral environment shutdown and build artifacts deleted. |
* fix(chart & alert): make to show metrics properly * fix(chart & alert): make to remove duplicate metrics * fix(chart & alert): make to restore metrics control alert slice * fix(chart & alert): make to fix lint issue
mistercrunch
added
🏷️ bot
SUMMARY
Altered Modal Doesn't Show Metrics Properly In Table Chart
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce bug
ADDITIONAL INFORMATION