Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes Tabs style #20050

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

It fixes the Tabs style.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-05-12 at 3 43 06 PM

Screen Shot 2022-05-12 at 3 41 57 PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #20050 (a423b78) into master (ee178f4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #20050   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1712     1712           
  Lines       64083    64083           
  Branches     6744     6744           
=======================================
  Hits        42523    42523           
  Misses      19847    19847           
  Partials     1713     1713           
Flag Coverage Δ
javascript 51.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Tabs/Tabs.tsx 95.83% <0.00%> (ø)
superset-frontend/src/views/components/SubMenu.tsx 86.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee178f4...a423b78. Read the comment docs.

@michael-s-molina michael-s-molina merged commit fff9ad0 into apache:master May 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants