-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Add create chart button in dashboard edit mode #20126
feat(dashboard): Add create chart button in dashboard edit mode #20126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20126 +/- ##
==========================================
- Coverage 66.47% 66.46% -0.01%
==========================================
Files 1721 1721
Lines 64477 64483 +6
Branches 6795 6795
==========================================
+ Hits 42858 42860 +2
- Misses 19891 19895 +4
Partials 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
buttonStyle="link" | ||
buttonSize="xsmall" | ||
onClick={() => | ||
window.open('/chart/add', '_blank', 'noopener noreferrer') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be interesting to implement broadcasting so that the list is updated when a chart is created: https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! But wouldn't we actually need to use websocket instead to update the list when chart is saved on the backend? I just wonder if such frontend communication would be reliable enough
SUMMARY
Clicking on "Create new chart" in "Charts" tab in dashboard edit mode button redirects to
/chart/add
view in a new tab.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
/chart/add
pageADDITIONAL INFORMATION
CC @kasiazjc