Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Database import with cancel_query.. extra field #20187

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

When we export database with cancel_query_on_windows_unload key in extra field, importing db is failed.
It is because the ImportV1DatabaseExtraSchema doesn't contain cancel_query_on_windows_unload as a property.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
importing database failed.

AFTER:
Sublime Text - PostgreSQL.yaml - 25 May 2022 - Watch Video

TESTING INSTRUCTIONS

  1. Edit a Database connection.
  2. Switch to the ADVANCED tab.
  3. Expand Performance.
  4. Enable/Disable Cancel query on window unload event.
  5. Save changes.
  6. Export the Database.
  7. Try to import it.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codemaster08240328 codemaster08240328 changed the title fix database import with cancel_query.. extra field fix: Database import with cancel_query.. extra field May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20187 (23c666a) into master (b746e6f) will decrease coverage by 11.92%.
The diff coverage is 46.51%.

❗ Current head 23c666a differs from pull request most recent head 2b13251. Consider uploading reports for the commit 2b13251 to get more accurate results

@@             Coverage Diff             @@
##           master   #20187       +/-   ##
===========================================
- Coverage   66.46%   54.53%   -11.93%     
===========================================
  Files        1721     1722        +1     
  Lines       64521    64640      +119     
  Branches     6811     6822       +11     
===========================================
- Hits        42882    35253     -7629     
- Misses      19906    27653     +7747     
- Partials     1733     1734        +1     
Flag Coverage Δ
hive 53.70% <46.47%> (-0.02%) ⬇️
mysql ?
postgres ?
presto 53.56% <46.47%> (-0.02%) ⬇️
python 58.00% <46.47%> (-24.64%) ⬇️
sqlite ?
unit 49.48% <46.47%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...ugin-chart-table/src/DataTable/hooks/useSticky.tsx 4.21% <0.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <ø> (ø)
...d/plugins/plugin-chart-table/src/transformProps.ts 64.44% <ø> (ø)
...c/SqlLab/components/ExploreResultsButton/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...end/src/components/PageHeaderWithActions/index.tsx 90.00% <ø> (ø)
...ponents/ReportModal/HeaderReportDropdown/index.tsx 68.00% <ø> (-1.34%) ⬇️
...dashboard/components/menu/ShareMenuItems/index.tsx 90.00% <ø> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <ø> (ø)
... and 297 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b746e6f...2b13251. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Jun 3, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

@rusackas Ephemeral environment spinning up at http://54.187.135.34:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 8097403 into apache:master Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Ephemeral environment shutdown and build artifacts deleted.

rdubois pushed a commit to ftom/superset that referenced this pull request Aug 30, 2022
ftom pushed a commit to ftom/superset that referenced this pull request Aug 30, 2022
Co-authored-by: Smart-Codi <codemaster08240328@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants