Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping min version of shillelagh #20196

Merged
merged 2 commits into from
May 31, 2022

Conversation

AAfghahi
Copy link
Member

SUMMARY

This bumps the minimum version of shillelagh to a higher minimum version to account for releases that have fixed some bugs with creating google sheets.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20196 (734bb53) into master (0501ad2) will decrease coverage by 12.06%.
The diff coverage is 58.75%.

❗ Current head 734bb53 differs from pull request most recent head 101abfb. Consider uploading reports for the commit 101abfb to get more accurate results

@@             Coverage Diff             @@
##           master   #20196       +/-   ##
===========================================
- Coverage   66.43%   54.36%   -12.07%     
===========================================
  Files        1722     1727        +5     
  Lines       64640    64721       +81     
  Branches     6822     6823        +1     
===========================================
- Hits        42944    35188     -7756     
- Misses      19962    27801     +7839     
+ Partials     1734     1732        -2     
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto 53.55% <39.53%> (-0.01%) ⬇️
python 57.61% <41.08%> (-25.01%) ⬇️
sqlite ?
unit 49.45% <34.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Modal/Modal.tsx 85.93% <ø> (-0.22%) ⬇️
...eModal/DatabaseConnectionForm/CommonParameters.tsx 90.00% <ø> (+4.28%) ⬆️
superset/db_engine_specs/bigquery.py 52.12% <ø> (-32.73%) ⬇️
superset/views/core.py 35.06% <0.00%> (-42.33%) ⬇️
superset/explore/form_data/api.py 51.06% <11.11%> (-44.77%) ⬇️
superset/temporary_cache/api.py 39.32% <11.11%> (-43.29%) ⬇️
...uperset/dashboards/filter_state/commands/update.py 40.00% <17.64%> (-60.00%) ⬇️
...uperset/dashboards/filter_state/commands/delete.py 45.83% <18.18%> (-50.01%) ⬇️
...uperset/dashboards/filter_state/commands/create.py 45.83% <37.50%> (-54.17%) ⬇️
superset/dashboards/filter_state/commands/utils.py 40.00% <40.00%> (ø)
... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0501ad2...101abfb. Read the comment docs.

@eschutho
Copy link
Member

did you run pip-compile-multi on this?

@AAfghahi
Copy link
Member Author

AAfghahi commented May 26, 2022

@eschutho no, but I don't think that you need to because shillelagh isn't on the list of required installs in the superset's setup.py. I think it is worth it to have it at the latest working version of shillelagh though so that people who are installing shillelagh have the current working version.

@AAfghahi
Copy link
Member Author

@eschutho ran pip-compile-multi --no-upgrade on this

@hughhhh hughhhh self-requested a review May 31, 2022 17:05
@AAfghahi AAfghahi merged commit e07ee6c into apache:master May 31, 2022
@AAfghahi AAfghahi deleted the ch48371_shillelaghBump branch May 31, 2022 17:10
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* bumping min version of shillelagh

* ran pip-compile-multi
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants