Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Implement viz switcher redesign #20248

Merged
merged 15 commits into from
Jun 14, 2022
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,13 @@ describe('VizType control', () => {
cy.visitChartByName('Daily Totals');
cy.verifySliceSuccess({ waitAlias: '@tableChartData' });

cy.get('[data-test="visualization-type"]').contains('Table').click();
cy.contains('View all charts').click();

cy.get('button').contains('Evolution').click(); // change categories
cy.get('[role="button"]').contains('Line Chart').click();
cy.get('button').contains('Select').click();
cy.get('.ant-modal-content').within(() => {
cy.get('button').contains('Evolution').click(); // change categories
cy.get('[role="button"]').contains('Line Chart').click();
cy.get('button').contains('Select').click();
});

cy.get('button[data-test="run-query-button"]').click();
cy.verifySliceSuccess({
Expand Down
21 changes: 21 additions & 0 deletions superset-frontend/src/assets/images/icons/area-chart-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/src/assets/images/icons/bar-chart-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions superset-frontend/src/assets/images/icons/line-chart-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions superset-frontend/src/assets/images/icons/pie-chart-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions superset-frontend/src/assets/images/icons/table-chart-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions superset-frontend/src/components/Icons/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ const IconFileNames = [
'alert',
'alert_solid',
'alert_solid_small',
'area-chart-tile',
'bar-chart-tile',
'big-number-chart-tile',
'binoculars',
'bolt',
'bolt_small',
Expand Down Expand Up @@ -56,6 +59,7 @@ const IconFileNames = [
'cog',
'collapse',
'color_palette',
'current-rendered-tile',
'components',
'copy',
'cursor_target',
Expand Down Expand Up @@ -101,6 +105,7 @@ const IconFileNames = [
'keyboard',
'layers',
'lightbulb',
'line-chart-tile',
'link',
'list',
'list_view',
Expand All @@ -123,6 +128,7 @@ const IconFileNames = [
'note',
'offline',
'paperclip',
'pie-chart-tile',
'placeholder',
'plus',
'plus_large',
Expand All @@ -141,6 +147,7 @@ const IconFileNames = [
'sort_desc',
'sort',
'table',
'table-chart-tile',
'tag',
'trash',
'triangle_change',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,6 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
defaultActiveKey={expandedQuerySections}
expandIconPosition="right"
ghost
key={`query-sections-${props.form_data.datasource}-${props.form_data.viz_type}`}
>
{showDatasourceAlert && <DatasourceAlert />}
{querySections.map(renderControlPanelSection)}
Expand All @@ -547,7 +546,6 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
defaultActiveKey={expandedCustomizeSections}
expandIconPosition="right"
ghost
key={`customize-sections-${props.form_data.datasource}-${props.form_data.viz_type}`}
>
{customizeSections.map(renderControlPanelSection)}
</Collapse>
Expand Down
Loading