-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embedded): enforce allow domains #20251
feat(embedded): enforce allow domains #20251
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20251 +/- ##
==========================================
- Coverage 66.65% 66.49% -0.17%
==========================================
Files 1729 1726 -3
Lines 64906 64799 -107
Branches 6842 6831 -11
==========================================
- Hits 43266 43090 -176
- Misses 19891 19977 +86
+ Partials 1749 1732 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this check in the backend, on the /embedded/:uuid view. If the domain is not in the list, we can return an error message instead of rendering the embedded page at all.
* feat(embedded): enforce allow domains * check referrer in view * remove frontend check
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION