Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule-query): getUISchema function called in SchemaForm component #20256

Merged
merged 32 commits into from
Jul 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e8e1e31
Merge pull request #2 from apache/master
Mar 23, 2022
0720ee6
Merge pull request #3 from apache/master
Mar 28, 2022
0d9405c
Merge pull request #4 from apache/master
Apr 3, 2022
7e4af14
Merge pull request #5 from apache/master
Apr 7, 2022
5938291
Merge pull request #6 from apache/master
Apr 11, 2022
2f039d7
Merge pull request #7 from apache/master
Apr 19, 2022
7f49f3a
Merge pull request #8 from apache/master
Apr 27, 2022
230438e
Merge pull request #9 from apache/master
May 6, 2022
c4debe6
Merge pull request #10 from apache/master
May 11, 2022
6d18661
Revert "Superset - Release and Improvements (12-05-2022)"
RahulRaj97 May 11, 2022
7ffe7dc
Merge pull request #12 from careem/revert-10-master
May 11, 2022
00d8c87
Merge branch 'master' of https://github.com/apache/superset into apac…
May 19, 2022
894c619
merging conflic changes
May 19, 2022
fd1af9a
Merge pull request #14 from careem/apache-new-master
May 19, 2022
9a3ee04
Revert "Revert "Superset - Release and Improvements (12-05-2022)""
May 19, 2022
bf8e88e
fixed breaking changes
May 19, 2022
595e9e6
Merge pull request #16 from careem/apache-latest
May 19, 2022
82e03b9
sync with master
May 19, 2022
6ce772b
Merge pull request #17 from careem/fix-apache-master
May 19, 2022
6c30d85
Merge pull request #18 from apache/master
May 23, 2022
2edf94a
fixed breaking flows
May 30, 2022
ef17cb8
Merge pull request #19 from apache/master
May 30, 2022
00a6937
fixed getUISchema function call
Jun 3, 2022
1be49e1
added default placeholder and updated docs
Jun 4, 2022
23f8812
fixed format and comments
Jun 4, 2022
153fbfd
changed flag to configuration
Jun 21, 2022
0a2735a
fix: indentation of SCHEDULED_QUERIES dict
Jul 1, 2022
f8b1d20
fix: changed intendation for SCHEDULED_QUERIES
Jul 1, 2022
8852b6c
fix: updated docs for SCHEDULED_QUERIES
Jul 1, 2022
58e21fe
fix: replaced button to menu item for SCHEDULED_QUERIES
Jul 1, 2022
6eae6dc
fix: updated docs for SCHEDULED_QUERIES
Jul 1, 2022
d60af23
fix: trailing whitespace
Jul 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Revert "Superset - Release and Improvements (12-05-2022)""
This reverts commit 6d18661.
  • Loading branch information
Rahul Raj committed May 19, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9a3ee049613166dd91670227725c254f34ad879d
10 changes: 2 additions & 8 deletions .github/workflows/bashlib.sh
Original file line number Diff line number Diff line change
@@ -183,7 +183,7 @@ cypress-run-all() {
nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
local flaskProcessId=$!

cypress-run "*/**/*"
cypress-run "*/**/!(*.applitools.test.ts)"

# After job is done, print out Flask log for debugging
say "::group::Flask log for default run"
@@ -198,7 +198,7 @@ cypress-run-all() {
nohup flask run --no-debugger -p $port >"$flasklog" 2>&1 </dev/null &
local flaskProcessId=$!

cypress-run "sqllab/*" "Backend persist"
cypress-run "sqllab/!(*.applitools.test.ts)" "Backend persist"

# Upload code coverage separately so each page can have separate flags
# -c will clean existing coverage reports, -F means add flags
@@ -213,12 +213,6 @@ cypress-run-all() {
kill $flaskProcessId
}

eyes-storybook-dependencies() {
say "::group::install eyes-storyook dependencies"
sudo apt-get update -y && sudo apt-get -y install gconf-service ca-certificates libxshmfence-dev fonts-liberation libappindicator3-1 libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libgconf-2-4 libglib2.0-0 libgdk-pixbuf2.0-0 libgtk-3-0 libnspr4 libnss3 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release xdg-utils libappindicator1
say "::endgroup::"
}

cypress-run-applitools() {
local flasklog="${HOME}/flask.log"
local port=8081
43 changes: 34 additions & 9 deletions .github/workflows/superset-applitool-cypress.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
name: Applitools Cypress

on:
schedule:
- cron: "0 1 * * *"
on: pull_request_target

jobs:
cypress-applitools:
runs-on: ubuntu-20.04
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
browser: ["chrome"]
node: [16]
env:
FLASK_ENV: development
SUPERSET_CONFIG: tests.integration_tests.superset_test_config
@@ -37,52 +35,79 @@ jobs:
- 16379:6379
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
uses: actions/checkout@v2
with:
persist-credentials: false
submodules: recursive
ref: master
- name: Check if python or frontend changes are present
id: check
env:
GITHUB_REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
continue-on-error: true
run: ./scripts/ci_check_no_file_changes.sh python frontend
- name: Setup Python
if: steps.check.outcome == 'failure'
uses: actions/setup-python@v2
with:
python-version: "3.8"
- name: OS dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: apt-get-install
- name: Install python dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: |
pip-upgrade
pip install -r requirements/testing.txt
- name: Setup postgres
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: setup-postgres
- name: Import test data
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: testdata
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
node-version: "16"
- name: Install npm dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: npm-install
- name: Build javascript packages
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: build-instrumented-assets
- name: Install cypress
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
with:
run: cypress-install
- name: Run Cypress
- name: Run Applitools Cypress
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
env:
CYPRESS_BROWSER: ${{ matrix.browser }}
with:
run: cypress-run-applitools
batch-completion-notification:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
needs: cypress-applitools
steps:
- name: Update Applitools batch status
uses: wei/curl@v1.1.1
env:
APPLITOOLS_BATCH_ID: ${{ github.sha }}
APPLITOOLS_API_KEY: ${{ secrets.APPLITOOLS_API_KEY }}
with:
args: -d "" -X POST https://eyesapi.applitools.com/api/externals/github/servers/github.com/commit/${{ env.APPLITOOLS_BATCH_ID }}/complete?apiKey=${{ env.APPLITOOLS_API_KEY }}
22 changes: 8 additions & 14 deletions .github/workflows/superset-applitools-storybook.yml
Original file line number Diff line number Diff line change
@@ -12,29 +12,23 @@ env:

jobs:
cron:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
matrix:
node: [16]
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
with:
persist-credentials: false
submodules: recursive
ref: master
- uses: actions/checkout@v3
- name: Set up Node.js
uses: actions/setup-node@v3.1.1
with:
node-version: ${{ matrix.node }}
- name: Install eyes-storybook dependencies
uses: ./.github/actions/cached-dependencies
with:
run: eyes-storybook-dependencies
- name: Install Chrome-related packages
run: sudo apt-get update -y && sudo apt-get -y install gconf-service ca-certificates libxshmfence-dev fonts-liberation libappindicator3-1 libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libgconf-2-4 libglib2.0-0 libgdk-pixbuf2.0-0 libgtk-3-0 libnspr4 libnss3 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release xdg-utils libappindicator1
- name: Install NPM dependencies
uses: ./.github/actions/cached-dependencies
with:
run: npm-install
working-directory: ./superset-frontend
run: |
npm ci
ls ./node_modules/puppeteer/.local-chromium
- name: Run Applitools Eyes-Storybook
working-directory: ./superset-frontend
run: npx eyes-storybook -u https://superset-storybook.netlify.app/
2 changes: 1 addition & 1 deletion .github/workflows/superset-e2e.yml
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '16'
node-version: "16"
- name: Install npm dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
Loading
Oops, something went wrong.