Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presto): use milliseconds timespec for presto #20333

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

mohittt8
Copy link
Contributor

@mohittt8 mohittt8 commented Jun 9, 2022

SUMMARY

Presto does not support microsecond. There is an open ticket to support microsecond/nanosecond for Presto(prestodb/presto#13063)
#19917 removed the from_iso8601_* functions but didn't change the timespec.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

Updated the testcases

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mohittt8 mohittt8 changed the title fix(presto): use correct timespec for presto fix(presto): use milliseconds timespec for presto Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #20333 (4e4a51e) into master (eab0009) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20333      +/-   ##
==========================================
+ Coverage   66.49%   66.60%   +0.10%     
==========================================
  Files        1734     1734              
  Lines       64996    64996              
  Branches     6871     6871              
==========================================
+ Hits        43219    43288      +69     
+ Misses      20020    19951      -69     
  Partials     1757     1757              
Flag Coverage Δ
hive 53.70% <0.00%> (?)
mysql 82.28% <100.00%> (ø)
postgres 82.35% <100.00%> (ø)
presto 53.56% <0.00%> (ø)
python 82.78% <100.00%> (+0.21%) ⬆️
sqlite 82.09% <100.00%> (ø)
unit 50.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 88.70% <100.00%> (ø)
superset/utils/core.py 90.14% <0.00%> (+0.11%) ⬆️
superset/connectors/sqla/models.py 90.23% <0.00%> (+0.18%) ⬆️
superset/db_engine_specs/base.py 88.42% <0.00%> (+0.33%) ⬆️
superset/db_engine_specs/hive.py 85.87% <0.00%> (+15.64%) ⬆️
superset/db_engines/hive.py 85.18% <0.00%> (+85.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab0009...4e4a51e. Read the comment docs.

@john-bodley john-bodley merged commit 41bbf62 into apache:master Jun 16, 2022
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jun 16, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mohittt8 mohittt8 deleted the presto-timestamp-fix branch June 27, 2022 08:44
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants