Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“results” should be more fine grained w/ access checks as sql_json #2038

Closed
wants to merge 12 commits into from

Conversation

wyndhblb
Copy link
Contributor

“results” should be more fine grained w/ access checks as sql_json not just full DB access.
Otherwise the async queries for users limited to either certain schemas or tables from a DB can never see the results. Since the query info is also in the result payload, we can determine the same access rights from it.

@bkyryliuk
Copy link
Member

@wyndhblb - I think we wrote the PRs almost at the same time,
#2032 - updates the permission check, I plan to merge it some time tomorrow.

@wyndhblb
Copy link
Contributor Author

yes it does looks like a similar thing. From my previous PR #2034 i was trying to figure out why it was all failing.

@mistercrunch
Copy link
Member

There's a lot of improvments in deprecate_v1 that should address this. Closing for now, reopen if I'm missing something after merging that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants