-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress translation warning in jest #20404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20404 +/- ##
==========================================
- Coverage 66.72% 66.70% -0.02%
==========================================
Files 1740 1739 -1
Lines 65175 65136 -39
Branches 6895 6897 +2
==========================================
- Hits 43486 43452 -34
+ Misses 19940 19931 -9
- Partials 1749 1753 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -81,3 +81,5 @@ setupSupersetClient(); | |||
jest.mock('src/hooks/useTabId', () => ({ | |||
useTabId: () => 1, | |||
})); | |||
|
|||
process.env.WEBPACK_MODE = 'test'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the environment variable WEBPACK_MODE
was defined at webpack.config.js. add a new value test
to determine if it is in the Jest process.
c5fd5da
to
4efc210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 9fad26f)
(cherry picked from commit 9fad26f)
SUMMARY
Suppress the "Duplicate translation" warning message in jest processor. test this PR by
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION