Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-chart-echarts): Support stacking negative and positive values #20408

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

Upgrade echarts to 5.3.3 to support stacking negative and positive values.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20408 (132b665) into master (1665403) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20408   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1739     1739           
  Lines       65135    65135           
  Branches     6897     6897           
=======================================
  Hits        43427    43427           
  Misses      19955    19955           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1665403...132b665. Read the comment docs.

@kgabryje kgabryje merged commit c959d92 into apache:master Jun 16, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jun 30, 2022
rusackas added a commit that referenced this pull request Jun 30, 2022
rusackas added a commit that referenced this pull request Jun 30, 2022
michael-s-molina pushed a commit that referenced this pull request Jul 6, 2022
…itive values (#20408)" (#20571)

This reverts commit c959d92.

(cherry picked from commit f5f8dde)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants