Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm eslint-plugin-translation-vars engines requirement #20420

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

It's no sense to require node engine in eslint-plugin-translation-vars.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #20420 (d73baff) into master (b32288f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20420   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files        1739     1739           
  Lines       65136    65136           
  Branches     6897     6897           
=======================================
  Hits        43452    43452           
  Misses      19931    19931           
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32288f...d73baff. Read the comment docs.

@stephenLYZ stephenLYZ merged commit fa7f144 into apache:master Jun 17, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants