Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move xaxis to superset-ui #20438

Merged
merged 5 commits into from
Jun 20, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jun 20, 2022

SUMMARY

In order to backward-compatible NVD3 chart,

  1. move the x-axis controls to superset-ui.
  2. the echarts plugins move constants into constats.ts from 'type.ts`.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No functional changes.

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #20438 (5e16c2f) into master (8b0bee5) will increase coverage by 0.00%.
The diff coverage is 68.18%.

❗ Current head 5e16c2f differs from pull request most recent head af14267. Consider uploading reports for the commit af14267 to get more accurate results

@@           Coverage Diff           @@
##           master   #20438   +/-   ##
=======================================
  Coverage   66.71%   66.71%           
=======================================
  Files        1739     1738    -1     
  Lines       65161    65162    +1     
  Branches     6899     6895    -4     
=======================================
+ Hits        43469    43474    +5     
  Misses      19939    19939           
+ Partials     1753     1749    -4     
Flag Coverage Δ
javascript 51.77% <46.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/plugin-chart-echarts/src/BoxPlot/types.ts 0.00% <ø> (ø)
.../plugin-chart-echarts/src/Funnel/transformProps.ts 71.73% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/types.ts 100.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/types.ts 100.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/types.ts 100.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.07% <ø> (ø)
...tend/plugins/plugin-chart-echarts/src/Pie/types.ts 100.00% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0bee5...af14267. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 111affd into apache:master Jun 20, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants