Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create echarts query section #20445

Merged

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Currently, the charts of Echarts timeseries contain same query section so move the query controls into a new section.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #20445 (7e61f6b) into master (111affd) will increase coverage by 0.00%.
The diff coverage is 54.16%.

❗ Current head 7e61f6b differs from pull request most recent head eec1815. Consider uploading reports for the commit eec1815 to get more accurate results

@@           Coverage Diff           @@
##           master   #20445   +/-   ##
=======================================
  Coverage   66.71%   66.72%           
=======================================
  Files        1738     1740    +2     
  Lines       65162    65175   +13     
  Branches     6895     6895           
=======================================
+ Hits        43474    43486   +12     
- Misses      19939    19940    +1     
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.77% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ui-core/src/chart/components/FallbackComponent.tsx 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 35.71% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 40.00% <ø> (ø)
...src/Timeseries/Regular/SmoothLine/controlPanel.tsx 40.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <ø> (ø)
...tend/plugins/plugin-chart-echarts/src/controls.tsx 72.72% <ø> (+3.16%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111affd...eec1815. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

@zhaoyongjie zhaoyongjie merged commit c79b0d6 into apache:master Jun 21, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants