Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(featureflags): add GENERIC_CHART_AXES flag #20446

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

novemberde
Copy link
Contributor

SUMMARY

I found that GENERIC_CHART_AXES flag exists via superset config file, but GENERIC_CHART_AXES is not described in the document.(This feature was applied via #17917)
This would be helpful for the superset user reading only documents.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ
Copy link
Member

Thanks for the suggestion! I think the only point we might need to check is whether to put it into stable or in testing. cc @rusackas @villebro

@zhaoyongjie zhaoyongjie changed the title doc(featureflags): add GENERIC_CHART_AXES flag docs(featureflags): add GENERIC_CHART_AXES flag Jun 21, 2022
@zhaoyongjie
Copy link
Member

@novemberde I think that the feature should still need polishing.

@novemberde
Copy link
Contributor Author

@zhaoyongjie Thank you for your review.
I've moved GENERIC_CHART_AXES feature to "in testing" block.

@zhaoyongjie zhaoyongjie requested a review from rusackas June 21, 2022 14:18
@srinify
Copy link
Contributor

srinify commented Jun 22, 2022

Thanks for the contribution!

@srinify srinify merged commit cf4f05e into apache:master Jun 22, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* doc(featureflags): add GENERIC_CHART_AXES flag

* move GENERIC_CHART_AXES into testing stage
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants