Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split Select component into Async and Sync components #20466

Merged
merged 13 commits into from
Jul 7, 2022
Merged

chore: Split Select component into Async and Sync components #20466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cdab55b
Created AsyncSelect Component
cccs-RyanK Jun 17, 2022
df65c03
Merge branch 'master' of github.com:CybercentreCanada/superset into C…
cccs-RyanK Jun 22, 2022
3d6319a
modified import of AsyncSelect, removed async tests and prefixes from…
cccs-RyanK Jun 23, 2022
967f1b5
fixed various import and lint warnings
cccs-RyanK Jun 27, 2022
0caf31b
Merge branch 'master' of github.com:CybercentreCanada/superset into C…
cccs-RyanK Jun 29, 2022
cc549a5
fixing lint errors
cccs-RyanK Jun 29, 2022
7a165b4
fixed frontend test errors
cccs-RyanK Jul 6, 2022
684852a
fixed alertreportmodel tests
cccs-RyanK Jul 6, 2022
56c20f7
Merge branch 'master' into CLDN-1484-Split-Select-Component-into-Asyn…
cccs-RyanK Jul 7, 2022
405e8e4
removed accidental import
cccs-RyanK Jul 7, 2022
593c521
fixed lint errors
cccs-RyanK Jul 7, 2022
0483fe7
updated async select
cccs-RyanK Jul 7, 2022
e43cdd3
Merge branch 'master' of github.com:CybercentreCanada/superset into C…
cccs-RyanK Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/src/addSlice/AddSliceContainer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import React from 'react';
import { ReactWrapper } from 'enzyme';
import Button from 'src/components/Button';
import { Select } from 'src/components';
import { AsyncSelect } from 'src/components';
import AddSliceContainer, {
AddSliceContainerProps,
AddSliceContainerState,
Expand Down Expand Up @@ -72,7 +72,7 @@ async function getWrapper(user = mockUser) {

test('renders a select and a VizTypeControl', async () => {
const wrapper = await getWrapper();
expect(wrapper.find(Select)).toExist();
expect(wrapper.find(AsyncSelect)).toExist();
expect(wrapper.find(VizTypeGallery)).toExist();
});

Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/addSlice/AddSliceContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { getUrlParam } from 'src/utils/urlUtils';
import { URL_PARAMS } from 'src/constants';
import { isNullish } from 'src/utils/common';
import Button from 'src/components/Button';
import { Select, Steps } from 'src/components';
import { AsyncSelect, Steps } from 'src/components';
import { Tooltip } from 'src/components/Tooltip';

import VizTypeGallery, {
Expand Down Expand Up @@ -349,7 +349,7 @@ export default class AddSliceContainer extends React.PureComponent<
status={this.state.datasource?.value ? 'finish' : 'process'}
description={
<StyledStepDescription className="dataset">
<Select
<AsyncSelect
autoFocus
ariaLabel={t('Dataset')}
name="select-datasource"
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/components/DatabaseSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import React, { ReactNode, useState, useMemo, useEffect } from 'react';
import { styled, SupersetClient, t } from '@superset-ui/core';
import rison from 'rison';
import { Select } from 'src/components';
import { AsyncSelect, Select } from 'src/components';
import Label from 'src/components/Label';
import { FormLabel } from 'src/components/Form';
import RefreshLabel from 'src/components/RefreshLabel';
Expand Down Expand Up @@ -272,7 +272,7 @@ export default function DatabaseSelector({

function renderDatabaseSelect() {
return renderSelectRow(
<Select
<AsyncSelect
ariaLabel={t('Select database or type database name')}
optionFilterProps={['database_name', 'value']}
data-test="select-database"
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/components/Datasource/DatasourceEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import Alert from 'src/components/Alert';
import Badge from 'src/components/Badge';
import shortid from 'shortid';
import { styled, SupersetClient, t, withTheme } from '@superset-ui/core';
import { Select, Row, Col } from 'src/components';
import { Select, AsyncSelect, Row, Col } from 'src/components';
import { FormLabel } from 'src/components/Form';
import Button from 'src/components/Button';
import Tabs from 'src/components/Tabs';
Expand Down Expand Up @@ -548,7 +548,7 @@ function OwnersSelector({ datasource, onChange }) {
}, []);

return (
<Select
<AsyncSelect
ariaLabel={t('Select owners')}
mode="multiple"
name="owners"
Expand Down
Loading