Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: How to rotate SECRET_KEY #20482

Closed
wants to merge 1 commit into from

Conversation

sentabi
Copy link

@sentabi sentabi commented Jun 23, 2022

Additional information to rotate SECRET_KEY

SUMMARY

Add more information about how to rotate SECRET_KEY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Additional information to rotate SECRET_KEY
@sentabi sentabi changed the title How to rotate SECRET_KEY docs: How to rotate SECRET_KEY Jun 24, 2022

Add the new SECRET_KEY and PREVIOUS_SECRET_KEY to `superset_config.py`:

To change the SECRET_KEY, first run the superset, because we need to access the database. After the superset running, create `superset_config.py` on temporary folder, for example `/tmp/superset_config.py` with following content
Copy link
Member

@nytai nytai Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for a temp superset_config.py instead of the actual superset_config.py?

@rusackas
Copy link
Member

Closing, as I believe this was superseded by #23867 which has already merged.

If there's anything not addressed by that other PR, please leave a comment and we can touch it up. Thank you nonetheless for your contribution here, on such a critical piece of documentation.

@rusackas rusackas closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants