Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-add filter-box time granularity/column #20485

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: Re-add filter-box time granularity/column #20485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions superset-frontend/src/visualizations/FilterBox/controlPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,28 @@ export default {
},
},
],
[
{
name: 'show_sqla_time_granularity',
config: {
type: 'CheckboxControl',
label: t('Show time grain dropdown'),
default: false,
description: t('Check to include time grain dropdown'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per here I think the old labels where mixed, i.e., if Druid was enabled it would include the term SQL. I opted for the clearer labels/description.

},
},
],
[
{
name: 'show_sqla_time_column',
config: {
type: 'CheckboxControl',
label: t('Show time column'),
default: false,
description: t('Check to include time column dropdown'),
},
},
],
['adhoc_filters'],
],
},
Expand Down