-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add liveness and readiness for deployment webserver #20567
feat(helm): add liveness and readiness for deployment webserver #20567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls bump the version in Chart.yaml
Still needs a version bump |
We can automate bump version, in my entreprise we automate bump version with label bump:minor, bump:major, bump;patch. is more easier and reduce error to bump version. |
You need to update the schema to get CI passing
|
Hi, i updated values schema, can you merge this PR ? |
Hi, any update on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is wrong order in variable name.
I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)? |
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
we can do this step by step, the PR is already open for several weeks. For the workers, do we have a status endpoint or a command to check the functioning? same for celery |
SUMMARY
We want add readiness and liveness in helmchart because we need liveness to restart container automatically when server crash and readiness for to delay start.
Is best practice in K8s to have liveness and readiness. :)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION