Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop missing columns control #20586

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

add a new control: Drop missing columns.
If this 1)option is checked and 2) all values in a column are null, this column will drop. The default value is uncheck, -- don't drop NA columns

Checking this control will skip some of the calculation in pivot operator, thus speeding up the pivot calculation.

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

drop.missing.column.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #20586 (9fcbdd8) into master (b870a21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20586   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files        1754     1754           
  Lines       65561    65562    +1     
  Branches     6933     6933           
=======================================
+ Hits        43793    43794    +1     
  Misses      20014    20014           
  Partials     1754     1754           
Flag Coverage Δ
javascript 51.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 50.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 51.66% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b870a21...9fcbdd8. Read the comment docs.

@zhaoyongjie
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

@zhaoyongjie Ephemeral environment spinning up at http://54.218.79.28:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as expected and LGTM!

@zhaoyongjie zhaoyongjie merged commit 309327d into apache:master Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants