-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(embedded): Ensure guest token is passed to log endpoint #20647
fix(embedded): Ensure guest token is passed to log endpoint #20647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20647 +/- ##
=======================================
Coverage 66.81% 66.81%
=======================================
Files 1753 1753
Lines 65806 65810 +4
Branches 7001 7001
=======================================
+ Hits 43966 43973 +7
+ Misses 20056 20053 -3
Partials 1784 1784
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5acf225
to
2bc4942
Compare
…0647) * Pass guest token to sendBeacon * Add tests
SUMMARY
Currently when using embedding a dashboard, calls to the
/log/
endpoint return a 401 response. This is becausenavigator.sendBeacon
was not sending the guest token used for authentication in the way thatSupersetClient
does.This PR will ensure the guest token is included so that event logging works for embedded dashboards.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
/log/
ADDITIONAL INFORMATION