Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Databricks views showing up as tables #20674

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: Databricks views showing up as tables #20674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion superset/db_engine_specs/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
# under the License.

from datetime import datetime
from typing import Any, Dict, Optional, TYPE_CHECKING
from typing import Any, Dict, List, Optional, TYPE_CHECKING

from sqlalchemy.engine.reflection import Inspector

from superset.constants import USER_AGENT
from superset.db_engine_specs.base import BaseEngineSpec
Expand Down Expand Up @@ -87,3 +89,16 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
}
extra.update(BaseEngineSpec.get_extra_params(database))
return extra

@classmethod
def get_table_names(
cls,
database: "Database",
inspector: Inspector,
schema: Optional[str],
) -> List[str]:
tables = set(super().get_table_names(database, inspector, schema))
views = set(cls.get_view_names(database, inspector, schema))
actual_tables = tables - views

return list(actual_tables)