fix(line-chart): Formula Annotations on Line Charts are broken

[stephenLYZ]

SUMMARY

The reason is that the formula annotation is added to the formula calculation based on the value of the x-axis, which was previously considered to be a number. After we introduced the generic chart, the x-axis could be either time or categorical, and we need to deal with the different types.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-07-13.1.13.03.mov

after

2022-07-13.1.12.11.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20687 (c5e1c89) into master (7f918a4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20687      +/-   ##
==========================================
- Coverage   66.85%   66.85%   -0.01%     
==========================================
  Files        1753     1753              
  Lines       65827    65837      +10     
  Branches     7006     7009       +3     
==========================================
+ Hits        44010    44015       +5     
- Misses      20031    20036       +5     
  Partials     1786     1786              

Flag	Coverage Δ
javascript	51.95% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts	0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts	55.95% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts	50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts	84.40% <ø> (ø)
...ugins/plugin-chart-echarts/src/utils/annotation.ts	86.27% <100.00%> (+1.16%)	⬆️
...perset-frontend/src/addSlice/AddSliceContainer.tsx	59.61% <0.00%> (-7.06%)	⬇️
superset-frontend/src/addSlice/App.tsx	0.00% <0.00%> (ø)
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx	42.50% <0.00%> (ø)
...kages/superset-ui-core/src/query/processFilters.ts	100.00% <0.00%> (+8.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f918a4...c5e1c89. Read the comment docs.

[zhaoyongjie]

LGTM, Thanks for the fix.