Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Turkey map to Country Map #20698

Closed

Conversation

rizacavus
Copy link
Contributor

SUMMARY

Add Turkey map to Country Map.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

176891882-1392a241-d38a-4d41-a69f-539b58b893be

TESTING INSTRUCTIONS

Clone the repo and go to its root directory. Run the following shell commands:

cd superset-frontend && npm install
npm run plugins:storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #20698 (f233706) into master (290b89c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f233706 differs from pull request most recent head 338824b. Consider uploading reports for the commit 338824b to get more accurate results

@@            Coverage Diff             @@
##           master   #20698      +/-   ##
==========================================
- Coverage   66.80%   66.79%   -0.01%     
==========================================
  Files        1754     1752       -2     
  Lines       65572    65925     +353     
  Branches     6933     7016      +83     
==========================================
+ Hits        43804    44034     +230     
- Misses      20014    20107      +93     
- Partials     1754     1784      +30     
Flag Coverage Δ
javascript 51.95% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
superset-frontend/src/utils/getDatasourceUid.ts 50.00% <0.00%> (-50.00%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 36.47% <0.00%> (-29.73%) ⬇️
superset-frontend/src/components/Select/Select.tsx 67.78% <0.00%> (-19.67%) ⬇️
...i-chart-controls/src/shared-controls/constants.tsx 18.75% <0.00%> (-18.75%) ⬇️
superset-frontend/src/views/store.ts 72.22% <0.00%> (-7.78%) ⬇️
...perset-frontend/src/addSlice/AddSliceContainer.tsx 59.61% <0.00%> (-7.06%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 72.00% <0.00%> (-4.48%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 56.60% <0.00%> (-2.22%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 68.57% <0.00%> (-1.86%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290b89c...338824b. Read the comment docs.

@rizacavus
Copy link
Contributor Author

As this branch has been blocked and not replied by @srinify for 5 days, a New branch has opened and was asked to rollback what @srinify want. So this pull request closed.

@rizacavus rizacavus closed this Jul 22, 2022
@rizacavus rizacavus deleted the feat-addTurkeyMapToCountryMap branch July 23, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants