fix: Ensure main_dttm_col is adhered to for non-drag-and-drop #20712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jul 15, 2022
| @@ -289,14 +289,14 @@ const granularity_sqla: SharedControlConfig<'SelectControl', ColumnMeta> = { | |||
| mapStateToProps: state => { | |||
| const props: Partial<SelectControlConfig<ColumnMeta | QueryColumn>> = {}; | |||
| const { datasource } = state; | |||
| if (datasource?.columns[0]?.hasOwnProperty('main_dttm_col')) { | |||
| if (datasource?.hasOwnProperty('main_dttm_col')) { | |||
There was a problem hiding this comment.
The main_dttm_col property exists on the datasource object as opposed the associated columns.
Codecov Report
@@ Coverage Diff @@
## master #20712 +/- ##
=======================================
Coverage 66.83% 66.83%
=======================================
Files 1750 1750
Lines 65894 65894
Branches 7017 7017
=======================================
Hits 44041 44041
Misses 20067 20067
Partials 1786 1786
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
changed the title
john-bodley
changed the title
ktmud
approved these changes
Jul 15, 2022
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 15, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit a6abcd9)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a regression introduced in #19855 where for non-drag-and-drop the
main_dttm_colwasn't being adhered to when creating a new chart.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
Tested locally.
ADDITIONAL INFORMATION