Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change buttons to be only save and overwrite #20851

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 25, 2022

SUMMARY

Change the naming of the save dataset modal buttons when in explore:

Screen Shot 2022-07-25 at 1 08 01 PM

Screen Shot 2022-07-25 at 1 07 51 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #20851 (4cbb325) into master (e3c6380) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cbb325 differs from pull request most recent head 4902cc1. Consider uploading reports for the commit 4902cc1 to get more accurate results

@@           Coverage Diff           @@
##           master   #20851   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1757     1757           
  Lines       66860    66860           
  Branches     7077     7077           
=======================================
  Hits        44332    44332           
  Misses      20719    20719           
  Partials     1809     1809           
Flag Coverage Δ
javascript 51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/components/controls/DatasourceControl/index.jsx 75.24% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 3de641c into apache:master Jul 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants