Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other(mypy): Enable warn_unused_ignores #20884

Merged
merged 1 commit into from
Jul 29, 2022
Merged

other(mypy): Enable warn_unused_ignores #20884

merged 1 commit into from
Jul 29, 2022

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 27, 2022

SUMMARY

I'm not sure exactly why warn_unused_ignores was set to false, but this PR switches the flag to true to ensure the code remains clean as of any unnecessary # type: ignore comments. Given that Mypy is continually evolving and stubs added it's not uncommon for type resolution to change over time.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #20884 (9529337) into master (50d2e5a) will decrease coverage by 11.48%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           master   #20884       +/-   ##
===========================================
- Coverage   66.31%   54.83%   -11.49%     
===========================================
  Files        1758     1758               
  Lines       67008    67008               
  Branches     7107     7107               
===========================================
- Hits        44437    36744     -7693     
- Misses      20749    28442     +7693     
  Partials     1822     1822               
Flag Coverage Δ
hive 53.25% <33.33%> (ø)
mysql ?
postgres ?
presto 53.15% <33.33%> (ø)
python 57.84% <33.33%> (-23.71%) ⬇️
sqlite ?
unit 50.25% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 37.32% <20.00%> (-3.46%) ⬇️
superset/utils/core.py 62.88% <100.00%> (-27.36%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.30% <0.00%> (-68.68%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 280 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@john-bodley john-bodley force-pushed the john-bodley-patch-5 branch from a63df18 to 6b4696f Compare July 27, 2022 15:39
@john-bodley john-bodley force-pushed the john-bodley-patch-5 branch from 6b4696f to 1086037 Compare July 27, 2022 15:40
@john-bodley john-bodley changed the title Update setup.cfg other(mypy): Enable warn_unused_ignores Jul 27, 2022
@john-bodley john-bodley marked this pull request as ready for review July 27, 2022 15:44
@john-bodley john-bodley requested review from hughhhh and ktmud July 27, 2022 15:44
@john-bodley john-bodley force-pushed the john-bodley-patch-5 branch from 1086037 to 9529337 Compare July 29, 2022 05:58
@ktmud ktmud merged commit 8d0d778 into master Jul 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley-patch-5 branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants