fix: Explore scrolled down when navigating from dashboard #20962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20962 +/- ##
==========================================
- Coverage 66.35% 66.34% -0.02%
==========================================
Files 1766 1767 +1
Lines 67124 67144 +20
Branches 7129 7137 +8
==========================================
+ Hits 44541 44546 +5
- Misses 20759 20772 +13
- Partials 1824 1826 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://35.162.196.230:8080. Credentials are |
michael-s-molina
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
LGTM. I was not able to reproduce the bug anymore. I also tested the navigation flows and didn't find anything. Thanks for the fix @kgabryje!
|
Ephemeral environment shutdown and build artifacts deleted. |
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 4, 2022
(cherry picked from commit e4fc556)
eschutho
pushed a commit
that referenced
this pull request
Sep 20, 2022
(cherry picked from commit e4fc556)
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit e4fc556)
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sometimes when user entered Explore from Dashboard, Explore was scrolled down and user was stuck in that position. That's because Explore is sometimes mounted with initial scroll set to some value above 0. We are stuck in this position, because of
overflow: hiddenon body. It’s related to how react-router mounts components on navigation, but I haven’t been able to find an answer why this bug is so non-deterministic.We fix it by programmatically scrolling to top when SPA route pathname changes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The bug shown in the video shows up only from time to time. After this fix, Explore should always open normally.
Screen.Recording.2022-08-03.at.12.48.39.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @andrey-zayats