Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(snowflake): Remove wrong version info for snowflake #21024

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

martimors
Copy link
Contributor

This removes the part in the documentation for snowflake where it is claimed 1) we do not support sqlalchemy >=1.4 and 2) snowflake connector version must be pinned to an old version. AFAICT none of these are valid now, so removing.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This removes the part in the documentation for snowflake where it is claimed 1) we do not support sqlalchemy >=1.4 and 2) snowflake connector version must be pinned to an old version. AFAICT none of these are valid now, so removing.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@michael-s-molina michael-s-molina merged commit 1372b0d into apache:master Oct 7, 2022
@mtucker502
Copy link

mtucker502 commented Mar 1, 2023

The documentation may have been updated but the official docker image when extended produces the same sqlalchemy 1.4 errors.

Dockerfile:

FROM apache/superset:1.5.3

USER root

RUN pip install snowflake-sqlalchemy

USER superset

Error:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-superset 1.5.3 requires sqlalchemy!=1.3.21,<1.4,>=1.3.16, but you have sqlalchemy 1.4.46 which is incompatible.
apache-superset 1.5.3 requires typing-extensions<4,>=3.10, but you have typing-extensions 4.5.0 which is incompatible.
Successfully installed asn1crypto-1.5.1 cryptography-38.0.4 filelock-3.9.0 greenlet-2.0.2 oscrypto-1.3.0 pyOpenSSL-22.1.0 pycryptodomex-3.17 snowflake-connector-python-2.9.0 snowflake-sqlalchemy-1.3.1 sqlalchemy-1.4.46 typing-extensions-4.5.0

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants