Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): use getaddrinfo for hostname check to support ipv6 #21042

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

vin01
Copy link
Contributor

@vin01 vin01 commented Aug 10, 2022

fixes hostname validation: #21041

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #21042 (619c182) into master (ab6ec89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master   #21042    +/-   ##
========================================
  Coverage   66.26%   66.27%            
========================================
  Files        1769     1772     +3     
  Lines       67475    67774   +299     
  Branches     7171     7171            
========================================
+ Hits        44711    44914   +203     
- Misses      20933    21029    +96     
  Partials     1831     1831            
Flag Coverage Δ
hive 53.01% <0.00%> (-0.14%) ⬇️
mysql 80.81% <100.00%> (-0.12%) ⬇️
postgres 80.86% <100.00%> (-0.12%) ⬇️
presto 52.91% <0.00%> (-0.14%) ⬇️
python 81.33% <100.00%> (-0.13%) ⬇️
sqlite 79.38% <100.00%> (-0.21%) ⬇️
unit 50.63% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/network.py 37.93% <100.00%> (ø)
superset/tasks/cache.py 61.15% <0.00%> (-12.76%) ⬇️
superset/charts/filters.py 85.41% <0.00%> (-9.46%) ⬇️
superset/dashboards/filters.py 88.76% <0.00%> (-4.99%) ⬇️
superset/db_engine_specs/trino.py 69.02% <0.00%> (-4.38%) ⬇️
superset/datasets/api.py 87.29% <0.00%> (-1.05%) ⬇️
superset/views/utils.py 80.00% <0.00%> (-0.85%) ⬇️
superset/examples/birth_names.py 71.42% <0.00%> (-0.65%) ⬇️
superset/databases/schemas.py 98.23% <0.00%> (-0.37%) ⬇️
superset/security/manager.py 95.07% <0.00%> (-0.32%) ⬇️
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@betodealmeida betodealmeida merged commit 2aa3bb6 into apache:master Sep 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants