fix(plugin-chart-echarts): missing value format in mixed timeseries #21044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpark
force-pushed
the
fix--echart-mixed-timeseries-invalid-format
branch
from
9de6700 to
e63c41e
Compare
ktmud
approved these changes
Aug 11, 2022
| @@ -82,8 +83,9 @@ export const Timeseries = ({ width, height }) => { | |||
| logAxis: boolean('Log axis', false), | |||
| xAxisTimeFormat: 'smart_date', | |||
| tooltipTimeFormat: 'smart_date', | |||
| yAxisFormat: 'SMART_NUMBER', | |||
| yAxisFormat: '$,.2f', | |||
There was a problem hiding this comment.
Can this be a knob too? (either select or text)
justinpark
changed the title
justinpark
force-pushed
the
fix--echart-mixed-timeseries-invalid-format
branch
from
47bc2b8 to
9bcf219
Compare
Codecov Report
@@ Coverage Diff @@
## master #21044 +/- ##
==========================================
- Coverage 66.28% 66.27% -0.01%
==========================================
Files 1770 1770
Lines 67497 67509 +12
Branches 7171 7177 +6
==========================================
+ Hits 44738 44743 +5
- Misses 20928 20932 +4
- Partials 1831 1834 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinpark
added a commit
to justinpark/superset
that referenced
this pull request
Aug 11, 2022
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 17, 2022
…pache#21044) (cherry picked from commit f2478c8)
eschutho
pushed a commit
that referenced
this pull request
Sep 20, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Oct 5, 2022
AAfghahi
pushed a commit
that referenced
this pull request
Oct 6, 2022
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When we show values for a mixed time series chart (stacked bar + line chart), the value format won't be reflected in the values shown in the chart.
This commit updates mixed-timeseries' transformProps to include the missing formatter with dependent's attributes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
storybook
ADDITIONAL INFORMATION