-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Chromatic publishing to superset-frontend storybook #21095
Merged
hughhhh
merged 24 commits into
apache:master
from
preset-io:ericbriscoe/sc-51041/connect-storybook-to-chromatic-figma
Aug 23, 2022
Merged
feat: Add Chromatic publishing to superset-frontend storybook #21095
hughhhh
merged 24 commits into
apache:master
from
preset-io:ericbriscoe/sc-51041/connect-storybook-to-chromatic-figma
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ybook Adds new Github action to publish storybook builds to chromatic Adjusts configuration to support MDX story format Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic Fixes issue in ListViewCard stories that make the story build fail
Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic
… in Chromatic action
eschutho
reviewed
Aug 17, 2022
eschutho
reviewed
Aug 17, 2022
eschutho
reviewed
Aug 17, 2022
eric-briscoe
changed the title
feat: Add Chromatic publishing to superset-fronted storybook
feat: Add Chromatic publishing to superset-frontend storybook
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #21095 +/- ##
==========================================
+ Coverage 66.34% 66.39% +0.05%
==========================================
Files 1773 1781 +8
Lines 67689 67871 +182
Branches 7218 7239 +21
==========================================
+ Hits 44905 45064 +159
- Misses 20940 20949 +9
- Partials 1844 1858 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hughhhh
approved these changes
Aug 23, 2022
9 tasks
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 2.1.0
and removed
🚢 2.1.3
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new Github action to publish storybook builds to chromatic
Add Chromatic publishing to superset-fronted storybook
SUMMARY
Adds new Github action to publish storybook builds to chromatic
Fixes issue in ListViewCard stories that make the story build fail
https://www.chromatic.com/docs/github-actions
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION