Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fab): Expose the SqlMetricInlineView extra column listed in the legacy FAB API #21118

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Aug 18, 2022

SUMMARY

As mentioned in Slack we (Airbnb) are experiencing performance issues with the Superset v1 API—in relation to a large dataset—due to an inefficiency in how the underlying FAB API fetch metadata. We're restricted to using the legacy FAB API however not all columns (for our needs) are exposed and thus this PR exposes the metric extra column to the list of columns which are included when reading/listing the metric metadata.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Ran http://127.0.0.1:8000/sqlmetricinlineview/api/read?flt_0_table_id=1 and confirmed that the extra column was included.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested review from etr2460 and ktmud August 18, 2022 00:16
@john-bodley john-bodley changed the title [fab] Add extra to list of columns chore(fab): Add the metric extra column to list of columns listed in the legacy FAB API Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #21118 (166e190) into master (55304b0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21118   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1772     1772           
  Lines       67612    67612           
  Branches     7204     7204           
=======================================
  Hits        44832    44832           
  Misses      20938    20938           
  Partials     1842     1842           
Flag Coverage Δ
hive 53.17% <100.00%> (ø)
mysql 80.96% <100.00%> (ø)
postgres 81.02% <100.00%> (ø)
presto 53.07% <100.00%> (ø)
python 81.50% <100.00%> (ø)
sqlite 79.62% <100.00%> (ø)
unit 50.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/views.py 87.30% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 3c59a86 into apache:master Aug 18, 2022
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Aug 18, 2022
@john-bodley john-bodley deleted the john-bodley--sqlametric-list-columns-extra branch August 18, 2022 01:33
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Aug 18, 2022
@john-bodley john-bodley changed the title chore(fab): Add the metric extra column to list of columns listed in the legacy FAB API chore(fab): Expose the SqlMetricInlineView extra column listed in the legacy FAB API Aug 20, 2022
john-bodley added a commit that referenced this pull request Aug 20, 2022
john-bodley added a commit that referenced this pull request Aug 20, 2022
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Aug 20, 2022
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Aug 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants