-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fab): Expose the SqlMetricInlineView extra column listed in the legacy FAB API #21118
Merged
john-bodley
merged 1 commit into
apache:master
from
john-bodley:john-bodley--sqlametric-list-columns-extra
Aug 18, 2022
Merged
chore(fab): Expose the SqlMetricInlineView extra column listed in the legacy FAB API #21118
john-bodley
merged 1 commit into
apache:master
from
john-bodley:john-bodley--sqlametric-list-columns-extra
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
[fab] Add extra to list of columns
chore(fab): Add the metric extra column to list of columns listed in the legacy FAB API
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #21118 +/- ##
=======================================
Coverage 66.30% 66.30%
=======================================
Files 1772 1772
Lines 67612 67612
Branches 7204 7204
=======================================
Hits 44832 44832
Misses 20938 20938
Partials 1842 1842
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ktmud
approved these changes
Aug 18, 2022
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 18, 2022
(cherry picked from commit 3c59a86)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 18, 2022
(cherry picked from commit 3c59a86)
john-bodley
changed the title
chore(fab): Add the metric extra column to list of columns listed in the legacy FAB API
chore(fab): Expose the SqlMetricInlineView extra column listed in the legacy FAB API
Aug 20, 2022
Merged
9 tasks
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 20, 2022
…he legacy FAB API apache#21118 (apache#21142) (cherry picked from commit a27f246)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 20, 2022
…he legacy FAB API apache#21118 (apache#21142) (cherry picked from commit a27f246)
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 2.1.0
and removed
🚢 2.1.3
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As mentioned in Slack we (Airbnb) are experiencing performance issues with the Superset v1 API—in relation to a large dataset—due to an inefficiency in how the underlying FAB API fetch metadata. We're restricted to using the legacy FAB API however not all columns (for our needs) are exposed and thus this PR exposes the metric
extra
column to the list of columns which are included when reading/listing the metric metadata.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Ran http://127.0.0.1:8000/sqlmetricinlineview/api/read?flt_0_table_id=1 and confirmed that the
extra
column was included.ADDITIONAL INFORMATION