-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds drill to detail context menu to Table #21168
feat: Adds drill to detail context menu to Table #21168
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21168 +/- ##
==========================================
- Coverage 66.39% 66.36% -0.03%
==========================================
Files 1781 1781
Lines 67901 67930 +29
Branches 7246 7255 +9
==========================================
Hits 45085 45085
- Misses 20954 20982 +28
- Partials 1862 1863 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up FEATURE_DRILL_TO_DETAIL=true |
187f3b4
to
bab1ca9
Compare
Storybook has completed and can be viewed at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
@geido Ephemeral environment spinning up at http://54.191.215.56:8080. Credentials are |
Storybook has completed and can be viewed at |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Adds drill-to-detail context menu to Table chart when right-clicking on the rows. The context menu is only displayed if the table contains aggregated data.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-23.at.3.27.53.PM.mov
TESTING INSTRUCTIONS
1 - You should be able to right-click on the rows in a table with aggregated data.
2 - Check the value and formatted value when right-clicking
3 - You should NOT be able to right-click on the rows in a table with raw data.
ADDITIONAL INFORMATION