-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter with created_by for charts and dashboards #21199
feat: filter with created_by for charts and dashboards #21199
Conversation
Storybook has completed and can be viewed at |
Codecov Report
@@ Coverage Diff @@
## master #21199 +/- ##
==========================================
- Coverage 66.43% 66.25% -0.19%
==========================================
Files 1784 1784
Lines 68167 68185 +18
Branches 7265 7265
==========================================
- Hits 45290 45179 -111
- Misses 21008 21137 +129
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Storybook has completed and can be viewed at |
Storybook has completed and can be viewed at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a failing test that needs fixing. Code LGTM!
…ilykuang/chart-dashboard-created-by-filter
* feat: filter with created_by for charts and dashboards * add tests * update tests * update tests (cherry picked from commit 05354a9)
🏷️ preset:2022.35 |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION