Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update chromatic PR action to have access to Job outputs #21224

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix: Update chromatic PR action to have access to Job outputs #21224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/chromatic-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,13 @@ jobs:
chromatic-deployment:
# Operating System
runs-on: ubuntu-latest
# define outputs that can be used in the storybook-link-comment job
outputs:
storybookUrl: ${{ steps.chromatic-deploy.outputs.storybookUrl }}
buildUrl: ${{ steps.chromatic-deploy.outputs.buildUrl }}
# Job steps
steps:
- id: chromatic-deploy
- uses: actions/checkout@v1
- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -76,5 +81,5 @@ jobs:
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }}. Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }} '
body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }} Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }}'
})