Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): sql editor's name has lost after reload #21246

Conversation

justinpark
Copy link
Member

SUMMARY

This bug was introduced by #20852
Since the editorQuery updates the title key by name but PERSISTENT_QUERY_EDITOR_KEYS hasn't updated, the queryEditor name value in localStorage has been discarded.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-08-29 at 3 38 56 PM

After:

Screen Shot 2022-08-29 at 3 46 35 PM

TESTING INSTRUCTIONS

  • set false to SQLLAB_BACKEND_PERSISTENCE
  • Go to SqlLab
  • Add/Edit editor's name
  • refresh the page

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @lyndsiWilliams

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #21246 (fe78e13) into master (8772e2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21246   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files        1784     1784           
  Lines       68163    68163           
  Branches     7264     7264           
=======================================
  Hits        45285    45285           
  Misses      21010    21010           
  Partials     1868     1868           
Flag Coverage Δ
javascript 52.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/SqlLab/utils/reduxStateToLocalStorageHelper.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyndsiWilliams
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://54.68.173.23:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams
Copy link
Member

Can we get additional testing from QA before merging?

@lyndsiWilliams lyndsiWilliams added the need:qa-review Requires QA review label Aug 30, 2022
@john-bodley john-bodley merged commit ad6b98c into apache:master Aug 30, 2022
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Aug 30, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

justinpark added a commit to airbnb/superset-fork that referenced this pull request Sep 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants