-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test for SPA explore endpoints around missing datasets #21303
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21303 +/- ##
==========================================
- Coverage 66.61% 66.44% -0.18%
==========================================
Files 1791 1791
Lines 68539 68539
Branches 7310 7310
==========================================
- Hits 45656 45539 -117
- Misses 21002 21119 +117
Partials 1881 1881
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
"/api/v1/explore/?dataset_id=50000&dataset_type=table", | ||
) | ||
response.json["result"]["dataset"]["name"] == "[Missing Dataset]" | ||
assert response.status_code == 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we are expecting a 200
when no dataset was found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah same question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea this is the expected results whenever we hit explore with a unknown dataset, assuming product is okay with this for now but if this needs to change atleast we have a test to warrant expected result
SUMMARY
Added test to validate the proper response that we currently returning for missing/not found datasets
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION