fix(dashboard): Change text and icons in dashboard editmode #21305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change 'Markdown' to 'Text' in edit mode sidebar - Change default text in markdown editor
Codecov Report
@@ Coverage Diff @@
## master #21305 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 1798 1798
Lines 68824 68824
Branches 7331 7331
=======================================
Hits 45994 45994
Misses 20952 20952
Partials 1878 1878
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
geido
reviewed
Sep 2, 2022
There was a problem hiding this comment.
@agl-developer there's a Cypress test that needs fixing. I'll spin up a test env when that is fixed. Thanks!
|
@agl-developer Looks like another Cypress test is broken. |
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://34.217.85.239:8080. Credentials are |
# Conflicts: # superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
geido
approved these changes
Sep 30, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If user wants to add text to the dashboard, they have to go to "layout components" and choose "markdown". This is super not intuitive for users (findings from Sayya), especially as the icon is not related to the text.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION